Skip to content

Commit

Permalink
fix(nats-jetstream): correctly count messages that should be redelive…
Browse files Browse the repository at this point in the history
…red (waiting for ack) towards keda value (kedacore#3809)

* fix: keda now include the messages that should be retried in the count of pending messages used for scaling

Signed-off-by: Antoine Laffargue <antoine.laffargue@gmail.com>

* chore: update changelog

Signed-off-by: Antoine Laffargue <antoine.laffargue@gmail.com>

Signed-off-by: Antoine Laffargue <antoine.laffargue@gmail.com>
Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com>
  • Loading branch information
toniopelo authored and pedro-stanaka committed Jan 19, 2023
1 parent cdd1aef commit e6b0410
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ To learn more about our roadmap, we recommend reading [this document](ROADMAP.md
- **General:** Respect optional parameter inside envs for ScaledJobs ([#3568](https://github.com/kedacore/keda/issues/3568))
- **Azure Blob Scaler** Store forgotten logger ([#3811](https://github.com/kedacore/keda/issues/3811))
- **Prometheus Scaler:** Treat Inf the same as Null result ([#3644](https://github.com/kedacore/keda/issues/3644))
- **NATS Jetstream:** Correctly count messages that should be redelivered (waiting for ack) towards keda value ([#3787](https://github.com/kedacore/keda/issues/3787))

### Deprecations

Expand Down
2 changes: 1 addition & 1 deletion pkg/scalers/nats_jetstream_scaler.go
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ func (s *natsJetStreamScaler) getMaxMsgLag() int64 {

for _, consumer := range s.stream.Consumers {
if consumer.Name == consumerName {
return int64(consumer.NumPending)
return int64(consumer.NumPending + consumer.NumAckPending)
}
}
return s.stream.State.LastSequence
Expand Down

0 comments on commit e6b0410

Please sign in to comment.