Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
Implements new testing method. Currently we are testing BOTH simulations of crystal structures and REFINEMENT against a dummy data (default HoB2.1). After changing how the refinement is done by default, and by changing in the queriers (limiting the volume of the crystal structures coming frm COD, etc), Xerus became much stabler. Furthermore, we are catching problematic simulations in place instead now, so the simulation test is not necessary anymore. However, since GSASII uses it own CIF parser, some tests are still required. Therefore, the new testing is only the following:
Also:
We reran the new testing (togethrer with the new OPTIMADE API that gives more structures from OQMD) and we found that:
Closes #23