Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve building and fix NIF path #23

Merged
merged 1 commit into from
Feb 13, 2019
Merged

Improve building and fix NIF path #23

merged 1 commit into from
Feb 13, 2019

Conversation

bismark
Copy link
Contributor

@bismark bismark commented Feb 5, 2019

  • Use elixir_make for a more robust build process
  • Update Makefile to not recompile everytime
  • Fix NIF path issue

Re the NIF path, I was getting the following error when trying to use the library as a dependency:

  [warn] The on_load function for module Elixir.Excal.Interface.Recurrence.Iterator returned:
{:error, {:load_failed, 'Failed to load NIF library: \'dlopen(./priv/recurrence/iterator.so, 2): image not found\''}}

- Use elixir_make for a more robust build process
- Update Makefile to not recompile everytime
- Fix NIF path issue
@codecov
Copy link

codecov bot commented Feb 5, 2019

Codecov Report

Merging #23 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #23   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          26     26           
=====================================
  Hits           26     26

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4279815...b37fcbe. Read the comment docs.

@leeicmobile
Copy link

I had the same issue with the nif path, wads going to put in a PR with just that change in will hold off if this is getting merged.

@doughsay
Copy link
Collaborator

Sorry for the delay! I'll take a look at this ASAP and get it merged

@doughsay doughsay merged commit 6487755 into peek-travel:master Feb 13, 2019
@doughsay
Copy link
Collaborator

Thanks @bismark for the updates and fixes! Version 0.3.0 has been published to hex.

@bismark bismark deleted the fixes branch February 13, 2019 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants