Add "XTS" currency #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The "XTS" currency is an ISO 4217 specified currency for use in tests, so it stands to reason to explicitly support this currency to allow developers to have a reasonable currency for tests. As ISO 4217 does not specify any minor units for XTS, the minor unit will be `1` to be capable of validating rounding. Modifications: - Add: `XTS` currency definition Result: Developers should have access to the official ISO 4217 `XTS` test currency.
Mordil
added
enhancement
|
Code Climate has analyzed commit 424f4d2 and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
==========================================
+ Coverage 96.3% 96.31% +0.01%
==========================================
Files 6 6
Lines 487 489 +2
==========================================
+ Hits 469 471 +2
Misses 18 18
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The "XTS" currency is an ISO 4217 specified currency for use in tests, so it stands to reason to explicitly support
this currency to allow developers to have a reasonable currency for tests.
As ISO 4217 does not specify any minor units for XTS, the minor unit will be
1to be capable of validating rounding.Modifications:
XTScurrency definitionResult:
Developers should have access to the official ISO 4217
XTStest currency.