Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposing a few changes on this one:
config.h
ID67_DISABLE_UNDERGLOW
define that disables LED's 68-77 (the 10 LEDs on the underside of the board). This will allow self-compile users to disable these LEDs if they have boards that have a solid backplate, like a standard ID67, ID67V2, and ID67 Bestype. The "default" compiles will INCLUDE the LED's as QMK admin will want the base code to include all the features of the PCB.#ifdef
's to make the code more readable.id67.c
g_led_config
global, but the doc does state to keep to the {224, 64} window. This mapping in based on my spreadsheet method covered in my Gist. I've tested most of the animations, all the spirals are centred, & all the crosshair effects are in a "straight" line.#ifndef ID67_DISABLE_UNDERGLOW
to the matrix to optionally disable the underglow LEDs. Note this is a "if NOT def" ... so the default complies will always include the underglow.__attribute__ ((weak)) void rgb_matrix_indicators_user()
function to give the base compile a Caps-Lock LED function (as used in other 67's in the QMK repo).id67.h
__
instead ofKC_NO
to make it more readable).default_nug/*
&via_nug/*
default
andvia
keycaps, with appropriate note.readme.md
Final thoughts
*_nug
maps. @peepeetee, you have the PCB only test bench, can you check for me?--made with ♡, Vino Rodrigues