Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please rename montex "v2" to "v1rgb" #6

Merged
merged 7 commits into from
May 2, 2022
Merged

please rename montex "v2" to "v1rgb" #6

merged 7 commits into from
May 2, 2022

Conversation

vinorodrigues
Copy link
Collaborator

@vinorodrigues vinorodrigues commented Apr 30, 2022

Hello there @peepeetee!

Hope you are healthy .. I hear you're on lockdown :(

Okay - this is going to be a long explanation - but I'll try to simplify it.

It turns out that Idobao's Montex PCB has changed the board layout for the WS2812 LED array. The board that Lewis sent you was correct at the time - this is the board that was sold via the Drop sale.

That new board -- that Idobao has branded as "V2" -- is not the same. This new board has the KEYMAP the same as your effort/code/board, but the LED-MAP is not (the the WS2812 array is totally different) - rendering your code completely visually not correct for the branded V2 board. (It is still right for the original Montex RGB!)

The difference I can illustrate with the following picture.

  • Your PCB / code has the array starting at the bottom 4 LED's, entering middle top key and jumpring to bottom and then "Z"-loops upward all the way to the top. [red numbers in the picture, following the black line] (This is correct for that board)
  • The new "V2" PCB has LED no.1 at the top-right position and then "Z"-loops downward. [black numbers in the picture]

image

So you can imagine the confusion this is causing with the users!


So I was thinking that we should call your code "V1 RGB" ... or folder name "v1rgb". For @IDOBAOKB there's no need to change anything ... they can keep all the old branding as "IDOBAO MONTEX PAD RGB VERSION KEYBOARD KIT" for the "v1rgb", and keep the new "V2" board as ... "V2". This effort is more about how the code lives on QMK.

All I need from your side is to adapt the code you have on PR #15865 to this new "v1rgb" name. And you can do this by merging this code into the QMK PR.

I've done (and tested) all the code with a user (@willi-on-fire) and I've also done the code for the "v2" board (and there is a seperate, working, PR for that too, PR #16897).

I've also already created the VIA json files for both the "v1rgb" and the "v2" ... github.com/Idobao/the-via.keyboards/tree/vr-add-id27-v2/src/idobao/montex, and I will PR that to VIA once QMK accepts both 15865 and 16897.

All the work is done.

But I need your help - since you already have an open PR in QMK we can just amend yours instead of me creating a new one. And then clear the image flag on that PR.


Keep safe ;)

@vinorodrigues vinorodrigues changed the title please rename montex to "v1rgb" please rename montex "v2" to "v1rgb" Apr 30, 2022
@vinorodrigues vinorodrigues changed the base branch from master to montex_rgb April 30, 2022 23:55
@vinorodrigues vinorodrigues merged commit d7f1213 into peepeetee:montex_rgb May 2, 2022
@vinorodrigues vinorodrigues deleted the vr-montex-v1rgb branch May 2, 2022 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant