Upgrade mocha to 8.x.x release #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayaddison
changed the title
|
@pgte Might we be able to merge this upgrade? It's not a hugely exciting update but it does remove a bit of |
|
@jayaddison I no longer can maintain these packages. Perhaps @jimpick can or knows who can? |
jayaddison
changed the title
|
Let me know if there's anything else that could help for merge-readiness here @jimpick; I've updated the pull request to upgrade to mocha 8.x.x since that major version's now available; the largest change per their release notes is that NodeJS 10+ is required. |
|
cc @jimpick - this is a small version bump (and dependency re-arrangement) for |
|
Closing as stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change upgrades the
mochadependency forjs-delta-crdts-msgpack-codecto include a security fix (see the release details).The mocha project will not be backporting this fix to
mocha@5.x.x.This change also commits the NPMFrom viewing other projects, practices seem to differ here, so I've reverted this change.package-lock.json, since it is intended to be committed to source repositories.NB: The
^7.1.2version specification does not pin to7.1.2specifically; the caret (^) symbol only matches against the left-most digit when checking for upgrades. I figure it's useful to specify the full three-digit version that was most-recent at the time of writing.cc @pgte