Feature: Add iCloud support #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mksony
approved these changes
Sep 6, 2019
There was a problem hiding this comment.
The changes look good to me, I wonder a little bit if it is safe to do all the nested properties access when we parsed the xml, but this is probably not scope of this issue and was there previously.
Thanks @tripodsan for your contribution.
Good job @moalo for the finishing touches 🌮
I add my approval and maybe @tripodsan you can check if this change fixes your issue and then we can merge and publish a new version.
|
Oops, sorry @mksony, I haven't seen your reply :) The change looks good to me and the tests are still working without any changes so I suspect the change to be non-breaking. I'm going to publish it. |
|
Published as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #29
Changes
parser.js: Ignore attributes and strip tag prefixes during XML parse.This allows us to work with iCloud calendar style XML responses, which don't contain namespaces (
d:,cs:).