Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade dependencies #18

Merged
merged 3 commits into from
Jun 25, 2024
Merged

chore: upgrade dependencies #18

merged 3 commits into from
Jun 25, 2024

Conversation

irenama
Copy link
Contributor

@irenama irenama commented Jun 25, 2024

ah ok I see to update node I/we have to adjust the action as well

  • enhance action with runner for test-and-release (20.x)

@irenama irenama requested a review from jhnns June 25, 2024 12:32
@irenama irenama self-assigned this Jun 25, 2024
TypeScript seems to always bail out when there's one error.
@jhnns jhnns marked this pull request as ready for review June 25, 2024 20:54
// 💥 Expect error 2790: … must be optional.
delete person.name;
```

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@irenama I had to remove the support for multiple errors as the new TypeScript versions seems to only report one error at a time. So in this case it would first only report the first error. When that error got fixed, it reported the second one.

We need to check in our workshops where we specify more than one Expect error

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch for seeing the PR through 🙂

@jhnns jhnns merged commit e17480a into main Jun 25, 2024
1 check passed
@jhnns jhnns deleted the update branch June 25, 2024 21:03
Copy link

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants