Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parse Yarn JSON on any OS #80

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ezpuzz
Copy link

@ezpuzz ezpuzz commented Oct 8, 2018

yarn will always output a \n in json output between lines so we should use that instead of os.EOL

@jhnns
Copy link
Member

jhnns commented Dec 22, 2018

Thanks for the PR 👍

Can you tell me the OS and terminal where Updtr is not working as expected? AppVeyor runs our tests on Windows machines.

@ezpuzz
Copy link
Author

ezpuzz commented Dec 23, 2018

i think windows powershell, been a little while
i'll try to confirm
i did verify in yarn source that it is always a \n only though and that EOL changes on different systems.

@jhnns
Copy link
Member

jhnns commented Jan 7, 2019

Can you post a link to the yarn source code?

Could you also change all occurrences of EOL to \n? That might be the reason why the PR is not building on AppVeyor.

Could you also undo all format changes not related to this change?

I'd be happy to merge this PR asap 😁 🎉

@callmeberzerker
Copy link

Is there any update on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants