Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRPH-79 Enhancing Proposal Information #100

Merged
merged 3 commits into from
Sep 18, 2019
Merged

Conversation

ronakpatel3110
Copy link

No description provided.

@bobinson
Copy link

bobinson commented Sep 2, 2019

@ronakpatel3110 - Please provide detailed information about the changes made.

@ronakpatel3110
Copy link
Author

This PR includes changes for better UX. Added a new field(std::string fail_reason) in proposal_object to indicate why a proposal had failed to execute. Added a test case proposal_failure in authority_tests to test this change. This is non-consensus-changing change.

Copy link

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@oxarbitrage oxarbitrage merged commit ca4a02d into develop Sep 18, 2019
@srpatel19590
Copy link

CLI steps to reproduce:

  • begin_builder_transaction
  • add_operation_to_builder_transaction 2 [0,{"fee":{"amount":0,"asset_id":"1.3.0"},"from":"1.2.19","to":"1.2.20","amount":{"amount":10000000000000,"asset_id":"1.3.0"},"extensions":[]}] here the first argument is the handle return by begin_builder_transaction
  • propose_builder_transaction2 2 alice "2019-09-30T06:53:00" 0 true
  • approve_proposal alice "1.10.4" {"active_approvals_to_add" : ["alice"]} true Here 1.10.4 is the proposal object we created.
  • get_object 1.10.4 will return the json object with the field fail_reson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants