Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GRPH-111] Added get_asset_count API #140

Merged
merged 1 commit into from
Sep 23, 2019
Merged

[GRPH-111] Added get_asset_count API #140

merged 1 commit into from
Sep 23, 2019

Conversation

srpatel19590
Copy link

@srpatel19590 srpatel19590 commented Sep 20, 2019

An API call that can return the total number of assets available. This will be used to get rid of loading assets on UI

@srpatel19590 srpatel19590 marked this pull request as ready for review September 20, 2019 14:39
Copy link

@bobinson bobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provide steps for the QA to

  • create asset
  • test from the cli_wallet

Copy link

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks.

@srpatel19590 srpatel19590 changed the title Added get_asset_count API [GRPH-111] Added get_asset_count API Sep 23, 2019
@srpatel19590
Copy link
Author

Testing procedure:

  • connect cli_wallet to peerplays node
  • get current asset count by get_asset_count
  • create new asset using create_asset
  • get new asset count by get_asset_count . It should be incremented by 1.

@srpatel19590
Copy link
Author

Example cli commands

  • Get current asset count
unlocked >>> get_asset_count
get_asset_count
1
  • Create new asset
    create_asset "1.2.18" "DIV" 5 {"max_supply" : 10000000000,"market_fee_percent" : 0,"max_market_fee" : 10000000000,"issuer_permissions" : 79,"flags" : 0,"core_exchange_rate" : {"base": {"amount": 1,"asset_id": "1.3.0"},"quote": {"amount": 1,"asset_id": "1.3.1"}},"whitelist_authorities" : [],"blacklist_authorities" : [],"whitelist_markets" : [],"blacklist_markets" : [],"description" : "Bitcoin with precision 8"} {} true

  • Get asset count again

unlocked >>> get_asset_count
get_asset_count
2

@bobinson bobinson self-requested a review September 23, 2019 13:54
@bobinson bobinson merged commit 1cb494e into develop Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants