Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to have separate withdraw_vesting methods and single withdraw fee for multiple objects #163

Merged
merged 1 commit into from
Oct 6, 2019

Conversation

pbattu123
Copy link

Changes to have separate methods and single withdraw fee for multiple objects
Charge only single fee on withdrawing from multiple vest objects

@bobinson
Copy link

bobinson commented Oct 3, 2019

The build failure is because of the missing cli tests. This can be ignored as the Graphene fixes merged into GPOS will fix the issue.

@pbattu123 pbattu123 changed the title Changes to have separate methods and single withdraw fee for multiple objects Changes to have separate withdraw_vesting methods and single withdraw fee for multiple objects Oct 4, 2019
Copy link

@bobinson bobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bobinson bobinson added the ready2merge PRs reviewed and ready for merge, but not merged due to HF or other dependencies label Oct 4, 2019
@pbattu123 pbattu123 merged commit d5dffa6 into qa_gpos_18.04 Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready2merge PRs reviewed and ready for merge, but not merged due to HF or other dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants