Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SON-142] Fix the failed tests in SONs-base #176

Merged
merged 2 commits into from
Oct 14, 2019
Merged

[SON-142] Fix the failed tests in SONs-base #176

merged 2 commits into from
Oct 14, 2019

Conversation

gladcow
Copy link

@gladcow gladcow commented Oct 12, 2019

Fixes failed affiliate_tests and delete_son_test

QA Notes: tests/chain_test working correctly

@bobinson
Copy link

The build failure is due to an issue with Gitlab CI.

oxarbitrage
oxarbitrage approved these changes Oct 14, 2019
View reviewed changes
Copy link

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes the test issue. thanks.

@oxarbitrage oxarbitrage merged commit 6c8f4bf into feature/SONs-base Oct 14, 2019
@oxarbitrage oxarbitrage mentioned this pull request Oct 15, 2019
Merged
@srpatel19590 srpatel19590 mentioned this pull request Nov 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obucina obucina obucina approved these changes

@bobinson bobinson bobinson approved these changes

@oxarbitrage oxarbitrage oxarbitrage approved these changes

Assignees
No one assigned
Labels
merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gladcow @bobinson @obucina @oxarbitrage