Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BLOCKBACK-182] set extensions default values #222

Merged
merged 1 commit into from
Nov 25, 2019

Conversation

srpatel19590
Copy link

The extension section of chain parameters remains empty until the committee proposal is submitted. This is fixed by setting the default values of all extensions parameters.

Also, removed the old hardfork betting checks which were required to be removed after the hf.

@srpatel19590 srpatel19590 changed the title set extensions default values [BLOCKBACK-182] set extensions default values Nov 22, 2019
@pbattu123 pbattu123 self-requested a review November 22, 2019 13:58
Copy link

@pbattu123 pbattu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, This fix would help either QA or witness to check extension parameters (including GPOS)

Copy link

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@pbattu123 pbattu123 merged commit 0ecf2e8 into develop Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants