Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BLOCKBACK-186] Withdraw vesting bug fix #243

Merged
merged 2 commits into from
Dec 13, 2019
Merged

[BLOCKBACK-186] Withdraw vesting bug fix #243

merged 2 commits into from
Dec 13, 2019

Conversation

srpatel19590
Copy link

Fixed GPOS withdraw vesting issue

@bobinson
Copy link

  • Gitlab CI can be ignored if local build is successful
  • merging should not be done without @pbattu123 's approval.

@bobinson bobinson added the bug Something isn't working label Dec 12, 2019
@bobinson bobinson added the hardfork Needs hardfork label Dec 12, 2019
oxarbitrage
oxarbitrage suggested changes Dec 12, 2019
View reviewed changes
Copy link

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test case.Thanks.

pbattu123
pbattu123 approved these changes Dec 13, 2019
View reviewed changes
Copy link

@pbattu123 pbattu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good to me

oxarbitrage
oxarbitrage approved these changes Dec 13, 2019
View reviewed changes
Copy link

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect, thanks!

@pbattu123 pbattu123 merged commit b1f2ba5 into develop Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxarbitrage oxarbitrage oxarbitrage approved these changes

@pbattu123 pbattu123 pbattu123 approved these changes

Assignees

@srpatel19590 srpatel19590

Labels
bug Something isn't working hardfork Needs hardfork merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@srpatel19590 @bobinson @oxarbitrage @pbattu123