Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable mandatory plugins to have smooth transition for next release #299

Merged
merged 2 commits into from
Mar 6, 2020

Conversation

pbattu123
Copy link

On bringing new elasticsearch plugin changes, witness should be able to run default plugins without plugin options. At the same time, witness should run other mandatory plugins like "witness" if only "elasticsearch" and "es-objects" passes under plugin options.
Changes done to implement the above changes.
Note: we can't enable both account_history and elasticsearch plugins at the same time

@pbattu123
Copy link
Author

@obucina
Copy link

obucina commented Feb 27, 2020

Please note that plugin handling, enable/disable and configuration is changed very much in incoming software versions. These two PRs are reflection of changes from Bitshares, and the way we are handling plugins in SONs-base branch.

#122
#126

With these two changes, enabling and disabling plugin is a single word in config file, and default set of plugins is hardcoded. With these, porting additional plugins from Bitshares will be much easier.

You should consider adding these PRs into develop branch.

@bobinson
Copy link

@pbattu123 - is witness plugin needed for seed nodes as well in the case of Peerplays ?

@pbattu123
Copy link
Author

@pbattu123 - is witness plugin needed for seed nodes as well in the case of Peerplays ?

No, it's not required

@sonarcloud
Copy link

sonarcloud bot commented Mar 6, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pbattu123 pbattu123 merged commit ac10923 into develop Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants