Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GRPH-71] Fix failed app_test #93

Merged
merged 1 commit into from
Sep 2, 2019
Merged

[GRPH-71] Fix failed app_test #93

merged 1 commit into from
Sep 2, 2019

Conversation

gladcow
Copy link

@gladcow gladcow commented Aug 29, 2019

Fix for failed app_test. Can be used as a test for #92

@gladcow gladcow requested a review from bobinson August 29, 2019 11:10
Copy link

@bobinson bobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gladcow - please resolve the conflicts.

@gladcow
Copy link
Author

gladcow commented Aug 30, 2019

Looks like the main part of this fix was added in #96, so the remaining part is not really important. But I have had several fails for this test on my PC because of the small timeout, so I think that remaining part is still useful.

@bobinson
Copy link

bobinson commented Sep 2, 2019

@gladcow - do you still have the failures ?

did you try updating the fixes from #96 ?

@gladcow
Copy link
Author

gladcow commented Sep 2, 2019

@bobinson , yes, sometimes I has failures with merged #96 too

@bobinson bobinson self-requested a review September 2, 2019 13:45
Copy link

@bobinson bobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bobinson bobinson merged commit e44b04d into develop Sep 2, 2019
@bobinson bobinson added the merged label Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants