Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase block creation timeout to 2500ms #97

Merged
merged 12 commits into from
Sep 2, 2019
Merged

Conversation

obucina
Copy link

@obucina obucina commented Aug 30, 2019

https://peerplays.atlassian.net/browse/GRPH-61

https://github.com/bitshares/bitshares-core/pull/1266/files

Since beatrice is merged into develop branch, the original requirement to checkout from beatrice is changed.

Timeout changed, all tests, but 1 are successfull.

Contains PR #96

@obucina obucina self-assigned this Aug 30, 2019
@bobinson
Copy link

@obucinac which test case is failing ?

@obucina
Copy link
Author

obucina commented Aug 30, 2019

chain_bench

*** 1 failure is detected in the test module "C++ Benchmarks for Graphene Blockchain Database"

@obucina
Copy link
Author

obucina commented Aug 30, 2019

The failure is actually not about this change. Bitshares chain_test also fails, with same root cause, and error message, I checked it. Thats why I believe this PR is safe.

Bitshares

obucina@blockchain-dev:~/workareas/peerplays/bitshares-core/tests$ ./chain_bench 
Running 2 test cases...
2624475ms th_a       genesis_allocation.cpp:40     test_method          ] tmp.which(): 5 
2624475ms th_a       genesis_allocation.cpp:57     test_method          ] Running in debug mode.
2626470ms th_a       db_management.cpp:191         open                 ] Wiping object_database due to missing or wrong version
2626470ms th_a       object_database.cpp:100       wipe                 ] Wiping object database...
2626470ms th_a       object_database.cpp:102       wipe                 ] Done wiping object databse.
2626470ms th_a       object_database.cpp:115       open                 ] Opening object database from /tmp/graphene-tmp/3027-9959-6ec4-9323 ...
2626472ms th_a       object_database.cpp:124       open                 ] Done opening object database.
2626476ms th_a       db_management.cpp:225         open                 ] 10 assert_exception: Assert Exception
genesis_state.initial_timestamp != time_point_sec(): Must initialize genesis timestamp.
    {}
    th_a  db_init.cpp:235 init_genesis

    {}
    th_a  db_init.cpp:736 init_genesis
2626477ms th_a       db_management.cpp:225         open                 ] data_dir: /tmp/graphene-tmp/3027-9959-6ec4-9323 
2626478ms th_a       genesis_allocation.cpp:126    test_method          ] e.to_detail_string(): 10 assert_exception: Assert Exception
genesis_state.initial_timestamp != time_point_sec(): Must initialize genesis timestamp.
    {}
    th_a  db_init.cpp:235 init_genesis

    {}
    th_a  db_init.cpp:736 init_genesis
rethrow
    {"data_dir":"/tmp/graphene-tmp/3027-9959-6ec4-9323"}
    th_a  db_management.cpp:225 open 
unknown location(0): fatal error: in "genesis_and_persistence_bench": unknown type
/home/obucina/workareas/peerplays/bitshares-core/tests/benchmarks/genesis_allocation.cpp(47): last checkpoint: "genesis_and_persistence_bench" test entry

*** 1 failure is detected in the test module "C++ Benchmarks for Graphene Blockchain Database"

Peerplays

obucina@blockchain-dev:~/workareas/peerplays/peerplays/build/debug/tests$ ./chain_bench;
Running 2 test cases...
2598343ms th_a       genesis_allocation.cpp:41     test_method          ] tmp.which(): 5 
2598343ms th_a       genesis_allocation.cpp:54     test_method          ] Running in release mode.
2735741ms th_a       object_database.cpp:94        open                 ] Opening object database from /tmp/graphene-tmp/370e-452c-b37b-1466 ...
2735741ms th_a       object_database.cpp:100       open                 ] Done opening object database.
2735963ms th_a       db_management.cpp:152         open                 ] 10 assert_exception: Assert Exception
genesis_state.initial_timestamp != time_point_sec(): Must initialize genesis timestamp.
    {}
    th_a  db_init.cpp:318 init_genesis

    {}
    th_a  db_init.cpp:977 init_genesis
2735963ms th_a       db_management.cpp:152         open                 ] data_dir: /tmp/graphene-tmp/370e-452c-b37b-1466 
2736003ms th_a       genesis_allocation.cpp:127    test_method          ] e.to_detail_string(): 10 assert_exception: Assert Exception
genesis_state.initial_timestamp != time_point_sec(): Must initialize genesis timestamp.
    {}
    th_a  db_init.cpp:318 init_genesis

    {}
    th_a  db_init.cpp:977 init_genesis
rethrow
    {"data_dir":"/tmp/graphene-tmp/370e-452c-b37b-1466"}
    th_a  db_management.cpp:152 open 
unknown location(0): fatal error: in "genesis_and_persistence_bench": unknown type
/home/obucina/workareas/peerplays/peerplays/tests/benchmarks/genesis_allocation.cpp(48): last checkpoint: "genesis_and_persistence_bench" test entry

*** 1 failure is detected in the test module "C++ Benchmarks for Graphene Blockchain Database"

Copy link

@bobinson bobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bobinson bobinson merged commit cdc89c1 into develop Sep 2, 2019
@obucina obucina deleted the feature/GRPH-61 branch September 2, 2019 16:03
@bobinson bobinson added the merged label Sep 8, 2019
@pbsa-github pbsa-github restored the feature/GRPH-61 branch May 19, 2020 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants