-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase block creation timeout to 2500ms #97
Conversation
Docker for Ubuntu 18.04
- Reorder prevents unnecessary building of Boost libraries
@obucinac which test case is failing ? |
chain_bench *** 1 failure is detected in the test module "C++ Benchmarks for Graphene Blockchain Database" |
The failure is actually not about this change. Bitshares chain_test also fails, with same root cause, and error message, I checked it. Thats why I believe this PR is safe. Bitshares
Peerplays
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
https://peerplays.atlassian.net/browse/GRPH-61
https://github.com/bitshares/bitshares-core/pull/1266/files
Since beatrice is merged into develop branch, the original requirement to checkout from beatrice is changed.
Timeout changed, all tests, but 1 are successfull.
Contains PR #96