Cli wallet tests framework #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is for #59 |
pbattu123
reviewed
Sep 3, 2019
tests/cli/main.cpp
Outdated
| con.wallet_api_ptr->save_wallet_file(con.wallet_filename); | ||
|
|
||
| // attempt to give jmjatlanta some CORE | ||
| BOOST_TEST_MESSAGE("Transferring bitshares from Nathan to jmjatlanta"); |
There was a problem hiding this comment.
I would say core tokens instead of bitshares in the message.
There was a problem hiding this comment.
thanks, changed at 1d1193e
bobinson
approved these changes
Sep 6, 2019
This was referenced Sep 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit removes the cache from wallet call
get_accountthat do more harm than good and was removed from bitshares since a while(bitshares/bitshares-core#640).Second commit actually add the cli test framework with some test cases examples, more can be found in the bitshares version.
Sorry the delay on this, had a hard time making it work.