This repository has been archived by the owner on Apr 26, 2022. It is now read-only.
feat(nodes-migrator 4/4): implement the migrate task submit #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foreverneverer
force-pushed
the
migrate-node-four
branch
from
a1fb4fd to
274e671
Compare
foreverneverer
changed the title
foreverneverer
changed the title
foreverneverer
force-pushed
the
migrate-node-four
branch
from
13d98c3 to
1240280
Compare
foreverneverer
changed the title
levy5307
reviewed
Oct 11, 2021
| }() | ||
|
|
||
| for _, action := range acts.actionList { | ||
| if action.replica.gpid.String() == currentAction.replica.gpid.String() { |
There was a problem hiding this comment.
if action.replica.gpid.String() == currentAction.replica.gpid.String() && action.to.node.String() == currentAction.to.node.String() {
return true;
}
levy5307
approved these changes
Oct 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.