Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar location #8

Merged
merged 5 commits into from
Dec 3, 2023
Merged

Grammar location #8

merged 5 commits into from
Dec 3, 2023

Conversation

hildjj
Copy link
Contributor

@hildjj hildjj commented Dec 3, 2023

I'm not sure the status of this code. Have to review and figure out why I didn't submit it before.

@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (27b5253) 100.00% compared to head (41692d3) 98.23%.

Files Patch % Lines
lib/index.js 94.28% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main       #8      +/-   ##
===========================================
- Coverage   100.00%   98.23%   -1.77%     
===========================================
  Files            1        1              
  Lines           80      113      +33     
===========================================
+ Hits            80      111      +31     
- Misses           0        2       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hildjj hildjj marked this pull request as ready for review December 3, 2023 17:42
@hildjj
Copy link
Contributor Author

hildjj commented Dec 3, 2023

This code wasn't sent to PR before because it was waiting on a Peggy release, which has happened.

@hildjj hildjj merged commit d698cba into peggyjs:main Dec 3, 2023
3 checks passed
@hildjj hildjj deleted the grammar-location branch December 3, 2023 17:43
@hildjj hildjj mentioned this pull request Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants