Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests on es modules #399

Closed
hildjj opened this issue Mar 28, 2023 · 3 comments · Fixed by #460
Closed

Run tests on es modules #399

hildjj opened this issue Mar 28, 2023 · 3 comments · Fixed by #460
Assignees
@hildjj
Labels
enhancement New feature or request

Comments

@hildjj
Copy link
Contributor

hildjj commented Mar 28, 2023

When using --format es on the command line, with a grammar that includes import statements, I would like to be able to use -t and -T.

Import paths should be relative to either the output file (if specified), or to the grammar file (if no output specified). Tests should run in a vm/context like they do for commonjs.
@hildjj hildjj added the enhancement New feature or request label Mar 28, 2023
@hildjj hildjj self-assigned this Mar 30, 2023
@hildjj
Copy link
Contributor Author

hildjj commented Mar 30, 2023

I have this working, still need to write tests.

hildjj added a commit to hildjj/peggy that referenced this issue Mar 30, 2023
@hildjj
Adds support for running tests against es module output. Fixes peggyj…
34a2fe6 
…s#399.
@hildjj
Copy link
Contributor Author

hildjj commented Apr 1, 2023

Right now, the tests cause a node segfault.

Blocked on nodejs/node#44211

@hildjj
Copy link
Contributor Author

hildjj commented Apr 1, 2023

This bug has better information: nodejs/node#43205

hildjj added a commit to hildjj/peggy that referenced this issue Jan 27, 2024
@hildjj
Adds support for running tests against es module output. Fixes peggyj…
231bed4 
…s#399.
This was referenced Jan 28, 2024
Merged
Closed
hildjj added a commit to hildjj/peggy that referenced this issue Feb 13, 2024
@hildjj
Merge branch 'main' into stable
c8e31fb 
* main: (107 commits)
  Version update.  Check npmignore.  Audit CHANGELOG.md.
  4.0.0
  Update dependencies final time before release.
  Fix indentation in one part of examples/javascript.pegjs.  Fixes peggyjs#445.
  Code review issues
  Add developer docs.  Fixes peggyjs#466.
  Add directories when they don't exist, rather than throwing an error.  Fixes peggyjs#440.
  Update changelog.  Include peggyjs#463 as well.
  Fix peggyjs#379.  Move reportInfiniteRecursion to prepare phase, ensure that it doesn't keep going when it finds an error.
  Typo: 'rutimes'
  Mark IE as explicitly unsupported
  Switch to flat eslint config.  Lint minified output for web compat.
  Code review nits
  Add tests, fix up fromMem to not need gross hack.
  Adds support for running tests against es module output.  Fixes peggyjs#399.
  Slight wording tweak.  Double-checked that peggyjs#415 is fixed.
  Fixes peggyjs#434
  Update bundles as well
  Fixes peggyjs#450
  Update dependencies, including new lint rules.  Move to simpler tsconfig so that eslint can easily find the correct file.  Fix small lint issues with new rules.
  ...
hildjj added a commit that referenced this issue Feb 13, 2024
@hildjj
Merge branch 'main' into stable
792e1d7 
* main: (107 commits)
  Version update.  Check npmignore.  Audit CHANGELOG.md.
  4.0.0
  Update dependencies final time before release.
  Fix indentation in one part of examples/javascript.pegjs.  Fixes #445.
  Code review issues
  Add developer docs.  Fixes #466.
  Add directories when they don't exist, rather than throwing an error.  Fixes #440.
  Update changelog.  Include #463 as well.
  Fix #379.  Move reportInfiniteRecursion to prepare phase, ensure that it doesn't keep going when it finds an error.
  Typo: 'rutimes'
  Mark IE as explicitly unsupported
  Switch to flat eslint config.  Lint minified output for web compat.
  Code review nits
  Add tests, fix up fromMem to not need gross hack.
  Adds support for running tests against es module output.  Fixes #399.
  Slight wording tweak.  Double-checked that #415 is fixed.
  Fixes #434
  Update bundles as well
  Fixes #450
  Update dependencies, including new lint rules.  Move to simpler tsconfig so that eslint can easily find the correct file.  Fix small lint issues with new rules.
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hildjj hildjj

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Es test hildjj/peggy
1 participant
@hildjj