Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grammar with token "constructor" fails to generate #520

Closed
PaulGVernon opened this issue Jun 18, 2024 · 2 comments · Fixed by #521
Closed

Grammar with token "constructor" fails to generate #520

PaulGVernon opened this issue Jun 18, 2024 · 2 comments · Fixed by #521
Assignees
@hildjj

Comments

@PaulGVernon
Copy link

I noticed that the following grammar

a = "constructor"

fails in version 4.0.2 with

error parsing grammar
Cannot read properties of undefined (reading 'length')

This was not the case in version 3.0.2
@hildjj hildjj self-assigned this Jun 19, 2024
@hildjj
Copy link
Contributor

hildjj commented Jun 19, 2024

Validated, and I see where the problem is. Investigating solutions.

hildjj added a commit to hildjj/peggy that referenced this issue Jun 19, 2024
@hildjj
Fixes peggyjs#520. Ensure that default object properties can be used …
a43a17d 
…as literals
hildjj added a commit to hildjj/peggy that referenced this issue Jun 19, 2024
@hildjj
Regression tests for peggyjs#520.
ebfec8c
@hildjj hildjj mentioned this issue Jun 19, 2024
Merged
hildjj added a commit to hildjj/peggy that referenced this issue Jun 19, 2024
@hildjj
Regression tests for peggyjs#520.
81b5194
@hildjj
Copy link
Contributor

hildjj commented Jun 19, 2024

I'll do a release later today, after fixing #513 and #522.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hildjj hildjj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow "constructor" and other object properties as grammar literals hildjj/peggy
2 participants
@hildjj @PaulGVernon