Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

marshal: support encoding.TextMarshaler #374

Merged
merged 1 commit into from
Apr 28, 2020

Conversation

oncilla
Copy link
Contributor

@oncilla oncilla commented Apr 25, 2020

With this PR the encoder now supports encoding.TextMarshaler.
Additionally, a bug is fixed, where the encoder does not notice a pointer
field that implements the toml.Marshaler interface.

Time types need to be special cased, because they implement the encoding.TextMarshaler
interface. Otherwise, the previous behavior cannot be maintained.

fixes #373

With this PR the encoder now supports encoding.TextMarshaler.
Additionally, a bug is fixed, where the encoder does not notice a pointer
field that implements the toml.Marshaler interface.

fixes pelletier#373
@pelletier
Copy link
Owner

Looks good to me, thank you for taking care of it!

@pelletier pelletier merged commit 2b8e33f into pelletier:master Apr 28, 2020
@oncilla
Copy link
Contributor Author

oncilla commented Apr 28, 2020

Thank you for the quick merges. Very appreciated 👍

@oncilla oncilla deleted the text-marshaller branch April 28, 2020 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

marshal: support encoding.TextMarshaler
2 participants