Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more supported types for default values when unmarshaling #392

Merged
merged 1 commit into from
May 4, 2020
Merged

Add more supported types for default values when unmarshaling #392

merged 1 commit into from
May 4, 2020

Conversation

x-hgg-x
Copy link
Contributor

@x-hgg-x x-hgg-x commented May 1, 2020

This PR adds more supported types for default values when unmarshaling.

Fixes #391.

@codecov
Copy link

codecov bot commented May 1, 2020

Codecov Report

Merging #392 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #392      +/-   ##
==========================================
+ Coverage   95.09%   95.12%   +0.02%     
==========================================
  Files          10       10              
  Lines        2202     2214      +12     
==========================================
+ Hits         2094     2106      +12     
  Misses         68       68              
  Partials       40       40              
Impacted Files Coverage Δ
marshal.go 94.54% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b8e33f...897d13e. Read the comment docs.

@pelletier
Copy link
Owner

Nice quality of life improvement. Thank you for the PR!

@pelletier pelletier merged commit 3478219 into pelletier:master May 4, 2020
@x-hgg-x x-hgg-x deleted the default-values branch May 4, 2020 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support more types for default values when unmarshaling
2 participants