Marshal into empty interface{} #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows to marshal a TOML document into an empty `interface{}`, resulting
in a `map[string]interface{}`.
Fixes #432
Codecov Report
@@ Coverage Diff @@
## master #433 +/- ##
=======================================
Coverage 93.91% 93.92%
=======================================
Files 10 10
Lines 2433 2435 +2
=======================================
+ Hits 2285 2287 +2
Misses 107 107
Partials 41 41
Continue to review full report at Codecov.
|
|
Wow. So simple. Works great. Only had to change the import path to switch from BurntSushi1. 🏆 1 Although, some of our marshaling tests are not expecting inline tables, but I'll investigate that issue separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to marshal a TOML document into an empty
interface{}, resultingin a
map[string]interface{}.Fixes #432
cc @moorereason