Remove underscore regexps #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #440. ``` benchmark old ns/op new ns/op delta BenchmarkUnmarshalToml-8 269582 257032 -4.66% benchmark old allocs new allocs delta BenchmarkUnmarshalToml-8 2650 2650 +0.00% benchmark old bytes new bytes delta BenchmarkUnmarshalToml-8 127761 127030 -0.57% ```
pelletier
added
the
performance
Codecov Report
@@ Coverage Diff @@
## master #448 +/- ##
==========================================
+ Coverage 93.56% 93.57% +0.01%
==========================================
Files 10 10
Lines 2253 2257 +4
==========================================
+ Hits 2108 2112 +4
Misses 105 105
Partials 40 40
Continue to review full report at Codecov.
|
moorereason
reviewed
Oct 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #440
Remove the last use of regexps in the parser.
@moorereason
Fixes #440