Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #466: use type alias to make Tree and tomlValue props publicly av… #467

Merged
merged 2 commits into from
Jan 29, 2021
Merged

fix #466: use type alias to make Tree and tomlValue props publicly av… #467

merged 2 commits into from
Jan 29, 2021

Conversation

vincentserpoul
Copy link
Contributor

@vincentserpoul vincentserpoul commented Jan 28, 2021

…ailable

Issue: #466

Explanation of what this pull request does: allow access to private props

@codecov
Copy link

codecov bot commented Jan 28, 2021

Codecov Report

Merging #467 (bea6bd4) into master (ba1b12b) will decrease coverage by 0.71%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #467      +/-   ##
==========================================
- Coverage   93.60%   92.88%   -0.72%     
==========================================
  Files          10       11       +1     
  Lines        2266     2292      +26     
==========================================
+ Hits         2121     2129       +8     
- Misses        105      123      +18     
  Partials       40       40              
Impacted Files Coverage Δ
tomlpub.go 0.00% <0.00%> (ø)
marshal.go 95.91% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3430b0f...bea6bd4. Read the comment docs.

@pelletier
Copy link
Owner

Looks good to me. Do you also need setters methods as well?

@vincentserpoul
Copy link
Contributor Author

you re right, I will need it to rebuild the tree back from the sops tree.
added!

@pelletier pelletier merged commit c9a09d8 into pelletier:master Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants