Fix empty trees when using OrderPreserve #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd like to add the test to cover my case as well, so I am converting it to the draft for now |
|
Hey dear @pelletier. Thank you for a great product! I'd like to get it reviewed. |
|
Looks good! Thank you very much for the patch! |
|
Oh, that's quick =) Do you mind create a new release with this fix, please? |
pelletier
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: fixes #450
Empty trees cause overriding of any existing node with line 0. It's not fixing the mentioned issue completely, although it works 100% for the case I've faced today during playing around with the library.