Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

296 Enable XCM assets on Pendulum #339

Merged
merged 8 commits into from
Nov 21, 2023
Merged

296 Enable XCM assets on Pendulum #339

merged 8 commits into from
Nov 21, 2023

Conversation

b-yap
Copy link
Contributor

@b-yap b-yap commented Nov 8, 2023 •
edited
Loading

Closes #296 .

General overview of the changes:

  1. Supported assets/tokens continues to grow; decided to move them in another file, assets.rs:
    • contains all XCM values, found inside the xcm_assets module
    • contains all tokens issued natively, found inside the tokens module
      • the EURC token is defined here
    • contains the location of the of all native tokens, found inside the locations native_locations module
      • the location of the EURC token and the native currency is defined here
  2. All XCM assets and their corresponding locations are found inside runtime-common package
    • EQD, PDEX, USDC, BRZ assets and locations are defined here
  3. I renamed ASSET_PALLET_ID to ASSET_PALLET_INDEX to make it similar to how it's called as "index" in the construct_runtime sense.

Nice to have: convert to macro the functions inside the locations module.

@b-yap b-yap force-pushed the 296-enable-xcm-assets-on-pendulum branch from cb6c6aa to 486f0a2 Compare November 17, 2023 03:39
@b-yap b-yap requested a review from a team November 17, 2023 09:41
@b-yap b-yap marked this pull request as ready for review November 17, 2023 09:41
ebma
ebma reviewed Nov 17, 2023
View reviewed changes
Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, I just left some comments 👍

runtime/common/src/lib.rs Outdated Show resolved Hide resolved
runtime/pendulum/src/assets.rs Outdated Show resolved Hide resolved
runtime/pendulum/src/xcm_config.rs Outdated Show resolved Hide resolved
runtime/pendulum/src/assets.rs Outdated Show resolved Hide resolved
@b-yap b-yap requested a review from ebma November 20, 2023 07:07
@b-yap b-yap requested a review from ebma November 21, 2023 08:44
ebma
ebma approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good to me 👍

runtime/amplitude/src/xcm_config.rs Outdated Show resolved Hide resolved
@b-yap b-yap merged commit e7024c8 into main Nov 21, 2023
2 checks passed
@b-yap b-yap deleted the 296-enable-xcm-assets-on-pendulum branch November 21, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebma ebma ebma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable XCM assets on Pendulum
2 participants
@b-yap @ebma