-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Observability in library and statime linux #390
Observability in library and statime linux #390
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #390 +/- ##
==========================================
- Coverage 62.05% 61.09% -0.97%
==========================================
Files 55 56 +1
Lines 6903 7012 +109
==========================================
Hits 4284 4284
- Misses 2619 2728 +109 ☔ View full report in Codecov by Sentry. |
516401b
to
efeca5c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: Reverts #405 but I am fine with that as that did not fix the issue anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies, missed that sdoId still has the default serde deserializer, which is problematic as an sdo id should be below 2^12, which this doesn't enforce.
bb5e5d5
to
44bacdc
Compare
44bacdc
to
cc37eb1
Compare
This PR will add a Prometheus exporter, which will get its metrics from statime-linux via a Unix Domain Socket, very similar to how ntpd-rs does it.
It implements all currently available Instance datasets and exposes only a small set of metrics. The full exposure of metrics will be implemented in a separate PR