feat(oauth): Show an informative log when OAuthError is raised #2175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is similar to the way facebook/views.py logs an exception
pennersr
requested changes
Apr 25, 2019
| @@ -77,7 +77,9 @@ def _get_request_token(self): | |||
| raise OAuthError( | |||
| _('Invalid response while obtaining request token' | |||
| ' from "%s".') % get_token_prefix( | |||
| self.request_token_url)) | |||
| self.request_token_url) + | |||
| ' Response content: %s' % response.content.decode("utf-8") | |||
There was a problem hiding this comment.
content need not be in utf-8 format, you should simply use response.text to have the decoding transparently handled for you.
|
hi @ykdojo, are you interested to continue working on this PR? This is an improvement that is sorely needed. It would be a shame for your work to not be continued with a bit of correction.. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to the way facebook/views.py logs an exception.
This feature was requested on #2142.
Example log:
allauth.socialaccount.providers.oauth.client.OAuthError: Invalid response while obtaining request token from "api.twitter.com". Response content: <?xml version="1.0" encoding="UTF-8"?><errors><error code="415">Callback URL not approved for this client application. Approved callback URLs can be adjusted in your application settings</error></errors>