Failing test for get_login_redirect_url when LOGIN_ON_EMAIL_CONFIRMATION

[francoisfreitag]

I’m not yet sure how to fix this. It looks like a regression from 560cb24.

[pennersr]

That commit is a refactor that cleans up the adhoc handling of the email verification link as was the case before. And, in this case it causes a change in behavior. It now calls get_signup_redirect_url() instead of get_login_redirect_url() -- because, that is actually what the test case is doing. It is in the process of performing a signup.

So, while indeed a change in behavior, I do think the current behavior is the correct one and we should leave this as is.

[pennersr]

Thanks for the test -- that helps in tracking things down fast. I've adjusted it and committed it here:

5c48f11

[francoisfreitag]

Oops, thanks for your answer!
That’s indeed an issue from my codebase and it should have used get_signup_redirect_url() from the start. That’ll be easy to fix 👍.