add support trigger($eventName) and Cake\EventManager proxy

[samsonasik]

@gianarb this is to prove #118 and added Cake\EventManager proxy to prove ;)

[gianarb]

Thanks
Why have you drop the PennyEventManagerInterface? :)

This interface define a compatible event

[samsonasik]

because it make hard to implement proxy for other Event Manager, it will get error like: Cakephp\Event\EventManager dispatch must pass PennyEventManagerInterface, Cakephp\Event\Event passed. We need to create a driver class that implements PennyEventManagerInterface just to make a proxy works, Also, provide a string event as key/event name is more usable imo.

[gianarb]

We need to create a driver class that implements PennyEventManagerInterface just to make a proxy works

Yes without this step your events could not support setRequest or setResponse or setRouteInfo..
penny uses this methods https://github.com/pennyphp/penny/blob/master/src/App.php#L94
I understand that an unused interface is a bad practice.. But maybe this interface is helpful

Maybe we rename (I follow your old feedback) this event_manager in penny.event_manager.. :) The penny.event_managermanages only application flow.. :)

[samsonasik]

Ok, I understand, I will try to create separate PR for alternative that uses PennyEventInterface and proxy sample for cakephp.

Warm regards,

Abdul Malik Ikhsan

Pada 16 Nov 2015, pukul 15.32, Gianluca Arbezzano notifications@github.com menulis:

We need to create a driver class that implements PennyEventManagerInterface just to make a proxy works

Yes without this step your events could not support setRequest or setResponse or setRouteInfo.. And penny uses this methods https://github.com/pennyphp/penny/blob/master/src/App.php#L94

—
Reply to this email directly or view it on GitHub.

[gianarb]

Thanks :)

[samsonasik]

closing in favor of #120

[samsonasik]

@gianarb re-open, probably add another method: setupEvent(PennyInterface $event) for set event must be instance of PennyEventInterface ?

[samsonasik]

re-closing, seems not possible :p

[samsonasik]

Hm...., how about add triggerByEventName() ?

Warm regards,

Abdul Malik Ikhsan

Pada 16 Nov 2015, pukul 15.56, Gianluca Arbezzano notifications@github.com menulis:

Thanks :)

—
Reply to this email directly or view it on GitHub.