Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor Dispatcher #135

Merged
merged 1 commit into from
Nov 26, 2015
Merged

Conversation

samsonasik
Copy link
Member

  • Fixes @return docblock for Dispatcher::__invoke() to @return RouteInfo
  • assign $dispatch[2] as $params for more readable when apply to new RouteInfo
  • move create new RouteInfo process to separate private method.

@gianarb
Copy link
Contributor

gianarb commented Nov 26, 2015

It sounds good..
Thanks this PR remove duplicate code

gianarb pushed a commit that referenced this pull request Nov 26, 2015
@gianarb gianarb merged commit d8077f0 into pennyphp:master Nov 26, 2015
@samsonasik samsonasik deleted the refactor-dispatcher branch November 26, 2015 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants