Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more improvements #137

Merged
merged 5 commits into from
Nov 27, 2015
Merged

more improvements #137

merged 5 commits into from
Nov 27, 2015

Conversation

samsonasik
Copy link
Member

  • PHPDiFactory refactor to allow set useAnnotations when call:
PHPDiFactory::buildContainer($config, true);

uses 2nd parameter to set it.

  • EventManager documentation and its usage with PHPDiFactory
  • Fixes missing use statements in getting started documentation.

@gianarb
Copy link
Contributor

gianarb commented Nov 27, 2015

👍

@samsonasik
Copy link
Member Author

woot, scrutinizer score now 9.76 \m/

@samsonasik
Copy link
Member Author

https://scrutinizer-ci.com/g/pennyphp/penny/inspections/2a213cf5-c9f8-40e4-8710-6bff5431d187

gianarb pushed a commit that referenced this pull request Nov 27, 2015
Merge pull request #137 from samsonasik/improvement-phpdi-factory
309e795 
more improvements
@gianarb gianarb merged commit 309e795 into pennyphp:master Nov 27, 2015
@gianarb
Copy link
Contributor

gianarb commented Nov 27, 2015

Thanks

@samsonasik samsonasik deleted the improvement-phpdi-factory branch November 27, 2015 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsonasik @gianarb