Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes RouteInfoInterface type hint in handleRoute() method #141

Merged
merged 2 commits into from
Nov 28, 2015

Conversation

samsonasik
Copy link
Member

as the RouteInfoInterface type hint make RuntimeException never executed. It fixes now ;)

@@ -133,15 +133,13 @@ public function run($request = null, $response = null)
/**
* Handle Route.
*
* @param RouteInfoInterface $routeInfo
* @param $routeInfo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add mixed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done ;)

@samsonasik
Copy link
Member Author

it need rebase if #140 will be merged ;)

@gianarb
Copy link
Contributor

gianarb commented Nov 28, 2015

Thanks

gianarb pushed a commit that referenced this pull request Nov 28, 2015
Fixes RouteInfoInterface type hint in handleRoute() method
@gianarb gianarb merged commit a9f0935 into pennyphp:master Nov 28, 2015
@samsonasik samsonasik deleted the fix-wrong-typehint branch November 28, 2015 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants