Fix 139 #142
Merged
Fix 139 #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| private function handleRoute($routeInfo, PennyEventInterface $event) | ||
| { | ||
| private function handleRoute( | ||
| RouteInfoInterface $routeInfo, |
There was a problem hiding this comment.
remove RouteInfoInterface type hint
| @@ -133,13 +133,15 @@ public function run($request = null, $response = null) | |||
| /** | |||
| * Handle Route. | |||
| * | |||
| * @param mixed $routeInfo | |||
| * @param PennyEventInterface $event | |||
| * @param RouteInfoInterface $routeInfo | |||
There was a problem hiding this comment.
Why? The dispatch method triggers exceptions or return RouteInfo object
There was a problem hiding this comment.
but the exception won't be executed, as the type hint is RouteInfoInterface
There was a problem hiding this comment.
this is the internal method that handle RouteInfoInterface check, so param need accept not a RouteInfoInterface, so the RuntimeException will be executable!
|
I will re-create PR for it. |
|
@gianarb you're wrong on rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase #139