remove ->getContainer() call inside internal App class inside setUpEventWithRequestResponse() method

[samsonasik]

No description provided.

[gianarb]

I am not interested to remove this method..
Why would you remove it?

[samsonasik]

it is called in internal method, like on getEventManager(), we just use $this->container->get('event_manager');, if we call outside, we still can call $app->getContainer()

[samsonasik]

I don't remove the getContainer() method, I just remove its call, ->getContainer() inside App class, if we need call outside, we still can call $app->getContainer()

[samsonasik]

@gianarb I think the better PR title is "remove ->getContainer() call inside internal App class inside setUpEventWithRequestResponse() method" I will update PR title

[gianarb]

At the moment I don't see ways to remove this method.. Maybe we can remove it in the future ;)

[samsonasik]

why? this is called in inside setUpEventWithRequestResponse(), if we need call after instantiation, we still can call $app->getContainer(), but not inside App class, also, for consistency in compare with container call inside getEventManager() method.

[samsonasik]

again, I'm not remove getContainer() method, I just removed its call inside App class method, and for consistency with getEventManager() which is used $this->container instead.

[gianarb]

Thanks