Fixed #52 Replace http.flow with eventManager #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you should choose a naming strategy, I see both lowercase with dots and camel case :\ |
|
heh good feedback :D suggestions? :) |
|
use the snake_case, in this way you'll be able to distinguish immediately between code invocations and other concepts $object->get('doMethod'); // invokes ::doMethod() on the internal object
$object->get('event_manager'); // gets the implementation of the event manager |
gianarb
force-pushed
the
feature/name-http-flow
branch
from
ee92659 to
0f7e498
Compare
| @@ -37,7 +37,7 @@ require_once "./vendor/autoload.php"; | |||
|
|
|||
| $app = new \GianArb\Penny\App(); | |||
|
|
|||
| $app->getContainer()->get("http.flow")->attach("*", function ($event) { | |||
| $app->getContainer()->get("eventManager")->attach("*", function ($event) { | |||
gianarb
pushed a commit
that referenced
this pull request
Sep 12, 2015
Fixed #52 Replace http.flow with eventManager
|
Thanks at all! :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.