PHP-DI bootstrap configuration #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| @@ -44,7 +44,7 @@ class App | |||
| */ | |||
| public function __construct($router = null, ContainerInterface $container = null) | |||
| { | |||
| $this->container = $container ?: $this->buildContainer(Loader::load()); | |||
| $this->container = $container ?: self::buildContainer(Loader::load()); | |||
There was a problem hiding this comment.
can be static:: instead of self::
App::buildContainer is a static method that helps to build a basic container this update helps to create mocks (you can use it into the test to build perfect container for our tests) and now the container builder is more clear
gianarb
force-pushed
the
feature/improve-php-di-bootstrap
branch
from
95874b0 to
4ae0ba0
Compare
gianarb
pushed a commit
that referenced
this pull request
Sep 23, 2015
PHP-DI bootstrap configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
App::buildContainer is a static method that helps to build a basic container
this update helps to create mocks (you can use it into the test to build
perfect container for our tests) and now the container builder is more clear
This PR maybe unlocks decorator feature (php-di) and follow this feedback (thanks @mnapoli)
pennyphp/penny-skeleton-app#21 (comment)
ping @samsonasik :)