Refactoring default request and response #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ($request != null) ?: $request = $this->request; | ||
| ($response != null) ?: $response = $this->response; | ||
| ($request != null) ?: $request = ServerRequestFactory::fromGlobals(); | ||
| ($response != null) ?: $response = new Response(); |
There was a problem hiding this comment.
I think it can be more readable with:
$request = ($request !== null) ?: ServerRequestFactory::fromGlobals();
$response = ($response !== null) ?: new Response();also, !== instead of !=
There was a problem hiding this comment.
Your feedback doesn't run.. I merge this PR at the moment
There was a problem hiding this comment.
Ok, hopefully can recheck about that
gianarb
force-pushed
the
feature/default-request-response
branch
from
78c6c5d to
960c2e6
Compare
gianarb
pushed a commit
that referenced
this pull request
Sep 29, 2015
Refactoring default request and response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.