Create container factory #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -43,38 +43,13 @@ class App | |||
| */ | |||
| public function __construct(ContainerInterface $container = null) | |||
| { | |||
| $this->container = $container ?: static::buildContainer(Loader::load()); | |||
| $container = &$this->container; | |||
| $this->container = $container ?: Container\PHPDiFactory::buildContainer(Loader::load()); | |||
|
|
|||
| if ($container->has('router') == false) { | |||
There was a problem hiding this comment.
The $container variable is valid? Or should be $this->container?
There was a problem hiding this comment.
Tested! :) Now is more readable
There was a problem hiding this comment.
yeah comes from the method parameter... sorry miss-read at that time...
gianarb
force-pushed
the
feature/di-factory
branch
from
b93b8f0 to
27e1782
Compare
added 3 commits
October 3, 2015 00:23
gianarb
force-pushed
the
feature/di-factory
branch
from
27e1782 to
7455612
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference #77
@wdalmut