container usage clean up #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -46,11 +46,12 @@ public function __construct(ContainerInterface $container = null) | |||
| if ($container === null) { | |||
| $container = Container\PHPDiFactory::buildContainer(Loader::load()); | |||
| } | |||
| $this->container = $container; | |||
|
|
|||
| if ($container->has('router') == false) { | |||
| throw new Exception('Define router config'); | |||
| } | |||
There was a problem hiding this comment.
throw early, assign later.
samsonasik
force-pushed
the
container-clean-up
branch
from
167fca0 to
bc050e9
Compare
| @@ -105,7 +104,6 @@ public function run($request = null, $response = null) | |||
|
|
|||
| $event = new HttpFlowEvent('bootstrap', $request, $response); | |||
|
|
|||
| $container = $this->getContainer(); | |||
There was a problem hiding this comment.
getContainer() is only usable if called from outside/from App instance, as only return the container, use $this->container directly instead.
samsonasik
force-pushed
the
container-clean-up
branch
from
2e904f5 to
bec4f80
Compare
|
rebased. |
|
Scrutinizer error seems not related. |
|
scrutinzer now green yay ;) |
|
merge-able ? |
|
yes thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.