Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused $request and $response property #84

Merged
merged 1 commit into from
Oct 5, 2015
Merged

remove unused $request and $response property #84

merged 1 commit into from
Oct 5, 2015

Conversation

samsonasik
Copy link
Member

No description provided.

@gianarb
Copy link
Contributor

gianarb commented Oct 5, 2015

Thanks

@gianarb gianarb closed this Oct 5, 2015
@samsonasik
Copy link
Member Author

why close ? not merge ?

@gianarb
Copy link
Contributor

gianarb commented Oct 5, 2015

Because I'm crazy!!! 💃

@gianarb gianarb reopened this Oct 5, 2015
gianarb pushed a commit that referenced this pull request Oct 5, 2015
Merge pull request #84 from samsonasik/remove-unused-property
b2da50c 
remove unused $request and $response property
@gianarb gianarb merged commit b2da50c into pennyphp:master Oct 5, 2015
@gianarb
Copy link
Contributor

gianarb commented Oct 5, 2015

Sorry 👍

@samsonasik
Copy link
Member Author

any reason to not remove the $request and $response property?

@samsonasik samsonasik deleted the remove-unused-property branch October 5, 2015 08:13
@samsonasik
Copy link
Member Author

ok (y)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsonasik @gianarb