Build all from dependency injection

[gianarb]

At the moment this solution doesn't work.
This PR describe an idea.

I'm trying to build from DI the event_http_flow but
if I use only DI to build it the application doesn't work
Because ->get('request') and ->get('response') could not be set.

[samsonasik]

single quote

[samsonasik]

use $this->container instead of $this->getContainer() for internally call, as I cleaned up on previous PR

[gianarb]

getContainer is a private API :)

2015-10-08 10:57 GMT+02:00 Abdul Malik Ikhsan notifications@github.com:

In src/App.php
#88 (comment):

  *
  * @return mixed
  */
 public function run($request = null, $response = null)
 {

•    $request = $request ?: ServerRequestFactory::fromGlobals();
  

•    $response = $response ?: new Response();
  

•    $request = $request ?: $this->getContainer()->get("request");
  

•    $response = $response ?: $this->getContainer()->get("response");
  

use $this->container instead of $this->getContainer() for internally
call, as I cleaned up on previous PR

—
Reply to this email directly or view it on GitHub
https://github.com/pennyphp/penny/pull/88/files#r41490323.

Gianluca Arbezzano
www.gianarb.it

[samsonasik]

it's not, it writtten public function getContainer()

[gianarb]

This implementation creates an inconsistence, if you use $app->run($request, $response) container you will be different values.. but IMO in a limit case..

$app->run($request, $response) is very powerful but during tests

To change request and response in your application now you can override them by DiC.

@fntlnz @EmanueleMinotto @samsonasik feedback around this approach?

[EmanueleMinotto]

use single quotes

[samsonasik]

see https://github.com/pennyphp/penny/blob/master/src/App.php#L48-L51 , getContainer() only return container, and calling internally should not need to call getter, just call $this->container direclty

[gianarb]

Description

With this PR I try to build all by DiC, in my opinion this is a good improvement because now we can replace HttpEventFlow. Before of this improvement I created it into the run method 👎 .

To maintain this feature (powerful into the unit/functional test)

use Penny\App;
$app = new App();
$request = new \Request();
$response = new \Response();

$app->run($request, $response);

I wrote PennyEventInterface common for all http_flow_event implementations, it requires basic functions to execute the run() function.

[fntlnz]

Good job