Standard dispatch result #91

gianarb · 2015-10-16T15:11:15Z

This PR implements a new class RouteInfo to return a standard result of disptach method.

This object describe current route resolved by dispatcher and helps us to implement new router libraries.

Reference #16

samsonasik · 2015-10-17T07:50:50Z

src/App.php

-        $method = $routerInfo[1][1];
-        $function = (new ReflectionClass($controller))->getShortName();
+        if (!($routeInfo instanceof RouteInfoInterface)) {
+            throw new \RuntimeException('Dispatch does not return RouteInfo object');


move RuntimeException to use statement

RouteInfo is a new class that increase interoperability between router libraries, this is the result of dispatch and it contains all info necessary to complete the RUN

gianarb · 2015-10-17T18:42:09Z

Works! :) I have only a little problem with PHP 7..

fntlnz · 2015-10-18T01:47:34Z

As you can see here PHP 5 and 7 don't behave in exactly the same way but both leads to an error if an array is passed instead of a callback.

I think that the problem is in how $fastRouteInfo[1][1] is populated here by the router.

samsonasik · 2015-10-18T01:56:10Z

I've given a try to patch php7 issue in #92 , let see

gianarb · 2015-10-18T10:47:51Z

This fix doesn't sound good but works..
Idea?

samsonasik · 2015-10-18T10:57:09Z

seems weird as previously, [$controller, $method] should be callable, but probably can be a workaround solution for now ;)

samsonasik · 2015-10-18T11:23:56Z

btw, need additional tests

Feature/route info call user func approach

gianarb · 2015-10-19T07:42:08Z

Thanks at all! We have a RouteInfo! 👍

Standard dispatch result

wdalmut · 2015-10-19T12:04:07Z

src/Route/FastPsr7RouteInfo.php

+    private $callable;
+    private $params;
+
+    public static function matched($name, callable $callable, $params = [])


Why this method?

public function __construct($name, callable $callable, $params = []) { // ... }

Is not better? In that way you can simplify the RouteInfoInterface and let to the user the RouteInfo construction

$matched = new RouteInfo("name", function() {}, []);

Yes.. maybe it is more easy to use 💣 😄

In my opinion also because a match method is more related to the Router and not the matched route, do you agree?

Yes :).. are you interested to write a PR? Otherwise I write a PR this evening :)

Of course i will try with a new PR

wdalmut · 2015-10-19T12:05:09Z

src/Route/RouteInfoInterface.php

+
+interface RouteInfoInterface
+{
+    public static function matched($name, callable $callable, $params);


There is no reason to have this method in the RouteInfoInterface imho.

gianarb added the enhancement label Oct 16, 2015

gianarb added this to the 0.6.0 milestone Oct 16, 2015

samsonasik reviewed Oct 17, 2015
View reviewed changes

gianarb force-pushed the feature/route-info branch 5 times, most recently from 9652784 to d1cbd1c Compare October 17, 2015 18:31

Create RouteInfo object

2f8d26f

RouteInfo is a new class that increase interoperability between router libraries, this is the result of dispatch and it contains all info necessary to complete the RUN

gianarb force-pushed the feature/route-info branch from d1cbd1c to 2f8d26f Compare October 17, 2015 18:38

samsonasik mentioned this pull request Oct 18, 2015

try patch php7 call_user_func issue #92

Closed

Compatibility with PHP7

880b819

fntlnz added 2 commits October 19, 2015 09:12

Trying the call_user_func approach

281f181

Removed unuseful check

6383aae

fntlnz mentioned this pull request Oct 19, 2015

Feature/route info call user func approach #93

Merged

Gianluca Arbezzano added 2 commits October 19, 2015 09:35

Merge pull request #93 from fntlnz/feature/route-info-cuf

05a4cc5

Feature/route info call user func approach

Cs fix

75ea06c

gianarb pushed a commit that referenced this pull request Oct 19, 2015

Merge pull request #91 from pennyphp/feature/route-info

b1779e3

Standard dispatch result

gianarb merged commit b1779e3 into master Oct 19, 2015

gianarb mentioned this pull request Oct 19, 2015

RouteMatched Object #16

Closed

wdalmut reviewed Oct 19, 2015
View reviewed changes

gianarb deleted the feature/route-info branch October 25, 2015 15:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Standard dispatch result #91

Standard dispatch result #91

gianarb commented Oct 16, 2015

samsonasik Oct 17, 2015

gianarb commented Oct 17, 2015

fntlnz commented Oct 18, 2015

samsonasik commented Oct 18, 2015

gianarb commented Oct 18, 2015

samsonasik commented Oct 18, 2015

samsonasik commented Oct 18, 2015

gianarb commented Oct 19, 2015

wdalmut Oct 19, 2015

wdalmut Oct 19, 2015

gianarb Oct 19, 2015

wdalmut Oct 19, 2015

gianarb Oct 19, 2015

wdalmut Oct 19, 2015

wdalmut Oct 19, 2015

Standard dispatch result #91

Standard dispatch result #91

Conversation

gianarb commented Oct 16, 2015

Choose a reason for hiding this comment

gianarb commented Oct 17, 2015

fntlnz commented Oct 18, 2015

samsonasik commented Oct 18, 2015

gianarb commented Oct 18, 2015

samsonasik commented Oct 18, 2015

samsonasik commented Oct 18, 2015

gianarb commented Oct 19, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment