This repository has been archived by the owner on Oct 31, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Schulz <paul@mawsonlakes.org>
Signed-off-by: Paul Schulz <paul@mawsonlakes.org>
hirunatan
reviewed
Dec 9, 2021
Comment on lines
+49
to
+51
<p><strong>Note:</strong> The displayed layer name and it's contents are different things. For example, | ||
changing the layer name for a text layer does not change what is displayed in the viewport. This | ||
may cause some confusion when using components and text layers with overrides. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I don't understand this. For example I may have a label for a button, the layer name is "Text 1" and the contents are "Submit". Those are quite different things, indeed. How could anyone have confusion with them? Could you give me an example?
Hi Andres,
Thanks for your email.
An example.. me. (Sorry)
I changed the layer name for a text layer thinking that it would change the
text and it didnt.
Some of other tools that I use (nodered, inkscape) dont explicitly name the
objects/layers, so it caught me by surprise.
Cheers, I hope this explains my reasoning. There is probably a better way
of clarifying this.
Paul
…On Thu, 9 Dec 2021, 19:26 Andrés Moya, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In user-guide/components/index.njk
<#50 (comment)>:
> +<p><strong>Note:</strong> The displayed layer name and it's contents are different things. For example,
+changing the layer name for a text layer does not change what is displayed in the viewport. This
+may cause some confusion when using components and text layers with overrides.
Sorry, I don't understand this. For example I may have a label for a
button, the layer name is "Text 1" and the contents are "Submit". Those are
quite different things, indeed. How could anyone have confusion with them?
Could you give me an example?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#50 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAVLALQC2L7UHJKDJPUT3DUQBVMJANCNFSM5JTR4QZA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Sorry, I still don't get the point 😅
In Inkscape, text layers also have an explicit name that is different than
the text contents. Do you expect that changing the layer name the contents
also change?
![image](https://user-images.githubusercontent.com/1483050/145384423-4b6739b2-1fc0-49e2-8496-104f64561fd1.png)
|
It was just me being confused. (I am happy for you to remove/ignore my
'Note').
I dont think it helped that I had both a button(layer) called 'Button' with
text that said 'Button'. I wanted to change the text, but changed the wrong
thing, and was surprised when the software didnt do what I was expecting.
…On Thu, 9 Dec 2021, 21:42 Andrés Moya, ***@***.***> wrote:
Sorry, I still don't get the point 😅
In Inkscape, text layers also have an explicit name that is different than
the text contents. Do you expect that changing the layer name the contents
also change?
[image: image.png]
--
Este mensaje y sus archivos adjuntos van dirigidos exclusivamente a su
destinatario, y pudiendo contener información confidencial sometida a
secreto profesional, o cuya divulgación esté legalmente prohibida.
Cualquier opinión en él contenida es exclusiva de su autor y no representa
necesariamente la opinión de la empresa. Si ha recibido este mensaje por
error, le rogamos nos lo comunique de forma inmediata por esta misma vía y
proceda a su eliminación, así como a la de cualquier documento adjunto al
mismo. El correo electrónico vía Internet no es seguro y no se puede
garantizar que no haya errores ya que puede ser interceptado, modificado,
perdido o destruido, o contener virus. Cualquier persona que se ponga en
contacto con nosotros por correo electrónico se considerará que asume
estos
riesgos.
KALEIDOS OPEN SOURCE se reserva las acciones legales que le
correspondan contra todo tercero que acceda de forma ilegítima al
contenido
de cualquier mensaje externo procedente del mismo.
INFORMACIÓN PROTECCIÓN
DE DATOS. Responsable: KALEIDOS OPEN SOURCE (B86241973)
Le informamos que
sus datos identificativos y los contenidos en los correos electrónicos y
ficheros adjuntos pueden ser incorporados a nuestras bases de datos con la
finalidad de mantener relaciones profesionales y/o comerciales y, que
serán
conservados mientras se mantenga la relación. Si lo desea, puede ejercer
su
derecho a acceder, rectificar y suprimir sus datos y demás reconocidos
normativamente dirigiéndose al correo emisor o en los datos del
responsable. Para información y consultas visite nuestra web
https://kaleidos.net <https://kaleidos.net/>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#50 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAVLAP5BFHG7U7P5NEI4QTUQCD3JANCNFSM5JTR4QZA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Sorry for the delay (last week we in Kaleidos had the "piweek" (piweek.com) and nearly stopped other activities... I'm going to merge your PR and then remove the paragraph. The rest is very good, thanks a lot! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are aimed at improving the readability of the User Guide.