Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build error due to penumbra-proof-params use of Git LFS #29

Closed
redshiftzero opened this issue Feb 27, 2023 · 2 comments · Fixed by #36
Closed

Build error due to penumbra-proof-params use of Git LFS #29

redshiftzero opened this issue Feb 27, 2023 · 2 comments · Fixed by #36
Assignees
@conorsch

Comments

@redshiftzero
Copy link
Contributor

Galileo fails to build due to being unable to resolve Git LFS pointers is the dependency penumbra-proof-params. This can be seen in this CI job.

@plaidfinch found this issue indicating that Git LFS assets in dependencies is not supported by cargo: rust-lang/cargo#9692

During release of Lysithea (penumbra-zone/penumbra#2005) we temporarily used a path dependency to get galileo to build.

Another option suggested by @plaidfinch is to use a submodule, which @conorsch volunteered to take a look at.
@conorsch
Copy link
Contributor

We plan to use a submodule dependency for now, to keep our build infra on the rails. However, a submodule isn't ideal into the future. Part of why we maintain Galileo is that it gives us a perspective on what it's like to build external tools against Penumbra. Now that we're adding zk proofs, we don't want to require third-party developers to submodule-in the dependency. More investigation required for a long-term solution.

@redshiftzero redshiftzero mentioned this issue Feb 27, 2023
Closed
5 tasks
conorsch added a commit that referenced this issue Feb 28, 2023
@conorsch
build: set penumbra deps as relative path
cd7f0c9 
We recently started using git-lfs in the penumbra repo,
and cargo can't fetch lfs artifacts via a git dependency. For now, we'll
clone the penumbra repo side-by-side and build from relative path.

Refs #29.
@conorsch conorsch mentioned this issue Feb 28, 2023
Merged
conorsch added a commit that referenced this issue Feb 28, 2023
@conorsch
build: set penumbra deps as relative path
46c9914 
We recently started using git-lfs in the penumbra repo,
and cargo can't fetch lfs artifacts via a git dependency. For now, we'll
clone the penumbra repo side-by-side and build from relative path.

Refs #29.
conorsch added a commit that referenced this issue Feb 28, 2023
@conorsch
build: set penumbra deps as relative path
a766cc5 
We recently started using git-lfs in the penumbra repo,
and cargo can't fetch lfs artifacts via a git dependency. For now, we'll
clone the penumbra repo side-by-side and build from relative path.

Refs #29.
@conorsch
Copy link
Contributor

conorsch commented Mar 6, 2023

We went with a relpath for now, and are able to build successfully again. We'll need to revisit this, but we have a workaround for now.

@redshiftzero redshiftzero mentioned this issue Mar 21, 2023
Merged
@conorsch conorsch mentioned this issue Apr 24, 2023
Closed
@conorsch conorsch mentioned this issue Sep 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@conorsch conorsch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

move back to git dependencies penumbra-zone/galileo
2 participants
@conorsch @redshiftzero